Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement orthogonal regions #376

Closed
mbats opened this issue Dec 4, 2013 · 7 comments
Closed

Implement orthogonal regions #376

mbats opened this issue Dec 4, 2013 · 7 comments

Comments

@mbats
Copy link
Member

mbats commented Dec 4, 2013

Today it is possible to create multiple regions but it is not possible to describe orthogonal regions.
See : http://en.wikipedia.org/wiki/UML_state_machine#Orthogonal_regions

@mbats mbats modified the milestones: 4.0.0_M3, 4.0.0_M2 Mar 7, 2014
mbats added a commit that referenced this issue Apr 17, 2014
@mbats
Copy link
Member Author

mbats commented Apr 17, 2014

See branch compartments.

  • The region border should be dashed.
  • It should be possible to create vertical or horizontal regions depending on where the user create the second region. If he creates the second region East or West form the first one we will expect horizontal stack for the regions, else if he creates it North or South, it will be a vertical stack of regions.
  • There is also a small problem with the rounded corner and the border.

image

@mbats
Copy link
Member Author

mbats commented Apr 17, 2014

Related to ticket : https://support.jira.obeo.fr/browse/VP-573

@mbats mbats modified the milestones: 4.1.0, 4.0.0 Apr 30, 2014
@mbats mbats modified the milestones: 5.0.0, 4.1.0 Jun 11, 2014
@mPorhel
Copy link
Contributor

mPorhel commented Feb 10, 2015

"There is also a small problem with the rounded corner and the border."

I will look to draw the rounded corner only for the first and last region bottoms of horizontal stacks and for the last region bottom for the vertical stack to avoid issue with the borders (ad future label line separator)

@mbats mbats modified the milestones: 5.0.0, 6.0.0 Apr 2, 2015
@mbats
Copy link
Member Author

mbats commented May 12, 2015

@mPorhel
Copy link
Contributor

mPorhel commented Jun 24, 2015

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=470770 for the rounded corner issue. A patch set has been added to take the corner dimension to reduce the border line and draw the arcs of the corners. But for the moment, it only draw the arcs of the border attachment figure (Sirius display the left/top border of the compartment excepting the first one).

But IMO, in your case, you do not need rounded corner on the region if we correct the overlap issue.

Current draft patch set 1 result (rounded corner only on RegionContainer):
draft v1

Current draft patch set 2 result (rounded corner on RegionContainer and Region mappings):
borderwithcorner

@mPorhel
Copy link
Contributor

mPorhel commented Jun 24, 2015

The region border should be dashed.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=461590

@mbats mbats modified the milestones: 6.0.0, 6.1.0 Oct 19, 2015
@mbats
Copy link
Member Author

mbats commented Jul 28, 2016

Duplicate #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants