Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclaim Issue #410

Open
Vohras2 opened this issue Nov 23, 2019 · 6 comments
Open

Unclaim Issue #410

Vohras2 opened this issue Nov 23, 2019 · 6 comments

Comments

@Vohras2
Copy link
Collaborator

@Vohras2 Vohras2 commented Nov 23, 2019

Roku Told me to put a bug report up with this.

blob:https://imgur.com/23c37681-7d1f-472b-847c-0e1ddd46c9b7

@Valjean42

This comment has been minimized.

Copy link

@Valjean42 Valjean42 commented Nov 23, 2019

Uhh it doesnt let me see the picture, can you try to get a better link or something? :P

@Hiroku

This comment has been minimized.

Copy link
Collaborator

@Hiroku Hiroku commented Nov 23, 2019

The issue is this:
/unclaim (Landlord) with a radius, in a player claim that is not his own, says he doesn't have permission regardless of the actual permission nodes he has.

@Valjean42

This comment has been minimized.

Copy link

@Valjean42 Valjean42 commented Nov 23, 2019

i assume it's because of this line:
image
the function only checks for whether the claim's owner is the user (allowed to manage claims function returns true ONLY if the player is the claim's owner in case of player-owned claims), and does not check if the user of the command has any overriding permissions

@Valjean42

This comment has been minimized.

Copy link

@Valjean42 Valjean42 commented Nov 23, 2019

i suggest changing the line to something like this:
image
Considering i dont know the exact permission needed (cant find it for some reason) i leave that to hiro
Edit: the permission might be landlord.admin.plots, not sure though, as i cant find the place where permissions are assigned :P

@Hiroku

This comment has been minimized.

Copy link
Collaborator

@Hiroku Hiroku commented Nov 23, 2019

I think the appropriate node is probably landlord.admin.command.unclaim

@Valjean42

This comment has been minimized.

Copy link

@Valjean42 Valjean42 commented Nov 23, 2019

ok so i changed the line to:
image
and that makes it so /unclaim with a radius unclaims ALL claims in the radius, which is probably not the wanted outcome, so im gonna try to think of a wanted outcome and change the code accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.