chore(images): digest-pin verifier, controller, litellm, cloudflared#517
Closed
bussyjd wants to merge 1 commit into
Closed
chore(images): digest-pin verifier, controller, litellm, cloudflared#517bussyjd wants to merge 1 commit into
bussyjd wants to merge 1 commit into
Conversation
Extends the @sha256 digest discipline that x402-buyer and the frontend already carry to the remaining four images that ship as part of the embedded infrastructure. Tag-only refs (e.g. ghcr.io/obolnetwork/ x402-verifier:b13254e) are vulnerable to mutable-tag rewrites — the class of bug CLAUDE.md pitfall #12 documented as a real production fire. Pins: - x402-verifier:b13254e @ sha256:a8a7aa0ca4c35b0ddf6983fa6e3e5f8a3f64e44d8e506ebfd55e39de2bc0342d - serviceoffer-controller:b13254e @ sha256:f83bd7e55bdc5d87edb49c04e7fd9257097364e2d43e769c19dfd7c8b47d07af - litellm:sha-c16b156 @ sha256:9f112b51ac5a57d73cdd54103fb98d24eabaddd8689a9a285884dca6456dc86e - cloudflared:2026.3.0 @ sha256:6b599ca3e974349ead3286d178da61d291961182ec3fe9c505e1dd02c8ac31b0 Adds a regression test asserting every embedded manifest carries @sha256: on its image refs so a future dependency bump can't silently revert to tag-only. Dev-rewrite invariant (defaults.go:124 + setup.go:74 alternation regex) verified intact via go test ./internal/defaults/... ./internal/x402/...
6 tasks
Collaborator
Author
|
Superseded by bundle PR #536 — closing in favor of the consolidated merge target. Original branch and history preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Only
x402-buyerand the frontend image carried@sha256:digest pins. Tag-only refs are vulnerable to mutable-tag rewrites — exactly the class CLAUDE.md pitfall #12 codified after a real local-cluster incident. Extending digest discipline to the other four images closes the gap.Before
After
What's pinned
ghcr.io/obolnetwork/x402-verifier:b13254e@sha256:a8a7aa0c…0342dghcr.io/obolnetwork/serviceoffer-controller:b13254e@sha256:f83bd7e5…07afghcr.io/obolnetwork/litellm:sha-c16b156@sha256:9f112b51…c86ecloudflare/cloudflared:2026.3.0@sha256:6b599ca3…31b0(
x402-buyerandobol-stack-front-endalready digest-pinned — no change.)Digests resolved via
docker buildx imagetools inspect <ref> --format '{{ .Manifest.Digest }}'.Test plan
go build ./...cleango test ./internal/embed/... ./internal/defaults/... ./internal/x402/...greenTestEmbeddedImages_NamedImagesAreDigestPinned,TestEmbeddedImages_CloudflaredHelmTagIsDigestPinned) asserting@sha256:on every named imageTestCopyInfrastructure_DevModeRewritesDigestPinsandTestX402Manifest_DevModeRewritesPinsboth pass against the new combo-form pinsCompanion to
Architecture review surfaced this as the simplest open security item in PRs #513 / #330 follow-up.