refactor: relocate remaining bedag/raw helmfile releases into base chart#523
Closed
bussyjd wants to merge 1 commit into
Closed
refactor: relocate remaining bedag/raw helmfile releases into base chart#523bussyjd wants to merge 1 commit into
bussyjd wants to merge 1 commit into
Conversation
The infrastructure helmfile shipped 6 `bedag/raw` releases — a wrapper chart whose only job is to apply inline YAML through helmfile. With the `base` release already rendering every other YAML in `base/templates/`, the inline approach has zero remaining justification. This PR finishes the job by relocating all 6: - llm-buyer-podmonitor → base/templates/llm.yaml (appended) - erpc-httproute → base/templates/erpc.yaml (new file) - erpc-x402-middleware → base/templates/erpc.yaml - erpc-metadata → base/templates/erpc.yaml - obol-frontend-httproute → base/templates/obol-frontend.yaml (new file) - obol-frontend-rbac → base/templates/obol-frontend.yaml Net change to the rendering: zero. Same YAML, just sourced from the chart's templates directory instead of inlined in helmfile.yaml through the bedag/raw wrapper chart. Each relocated YAML carries a provenance comment. DAG: `base` now `needs: [traefik/traefik, monitoring/monitoring]` so the Traefik (Middleware) / Gateway API (HTTPRoute) / Prometheus operator (PodMonitor) CRDs are guaranteed present before the relocated templates apply. New Namespace docs for `erpc` and `obol-frontend` make the `base` release self-contained — the upstream chart releases that originally created those namespaces still set `createNamespace: true`, which is a no-op against an existing namespace. The `bedag` repository entry is removed (no infrastructure release uses it anymore). Network helmfiles + hermes still use bedag/raw — out of scope for this PR. `migrateDefaultsHTTPRouteHostnames` in internal/stack/stack.go targets the old in-helmfile HTTPRoute indentation pattern; it is a no-op against the relocated templates and against the new helmfile, preserved unchanged for users upgrading from older stacks. The `hostnames: ["obol.stack"]` restriction is preserved on every relocated HTTPRoute per CLAUDE.md guidance — removing it would expose the frontend / eRPC to the public cloudflared tunnel. `TestHelmfile_IncludesBuyerPodMonitor` rewired to read `base/templates/llm.yaml`. All embed CRD tests, stack tests, and go build are green.
This was referenced May 24, 2026
Collaborator
Author
|
Superseded by bundle PR #536 — closing in favor of the consolidated merge target. Original branch and history preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The infrastructure helmfile shipped 6
bedag/rawreleases — a wrapper chart whose only job is to apply inline YAML through helmfile. With thebaserelease already rendering every other YAML inbase/templates/, the inline approach has zero remaining justification — it's just duplicate machinery.Before
After
What changed
helmfile.yaml— removed all 6bedag/rawreleases; dropped thebedagrepository entry (no longer referenced by infrastructure)baserelease nowneeds: [traefik/traefik, monitoring/monitoring]so the Middleware / HTTPRoute / PodMonitor CRDs are present when the relocated templates applybase/templates/erpc.yamlcarries Namespace + HTTPRoute + Middleware + metadata ConfigMapbase/templates/obol-frontend.yamlcarries Namespace + HTTPRoute + discovery RBACbase/templates/llm.yamlinternal/embed/infrastructure/values/erpc-metadata.yaml.gotmplTestHelmfile_IncludesBuyerPodMonitorrewired to readbase/templates/llm.yamlWhy the
needs:change is safeHelmfile already serialises on
needs:— makingbasewait for traefik + monitoring just shifts the order, not the total work. All downstream releases that previouslyneeds: [kube-system/base]keep working unchanged.Why the new Namespace docs are safe
erpcandobol-frontendnamespaces are now created by both thebaserelease templates AND the upstream chart releases (which keepcreateNamespace: true).kubectl applyon an existing Namespace is a no-op.Test plan
go build ./...cleango test ./internal/embed/...greengo test ./internal/stack/...green (one pre-existing failure on main, unrelated:TestWarnIfNoChatModel_EmitsWarnWhenNoModelsexpects "No chat-capable LLM detected" but code emits "No chat-capable model detected")hostnames: ["obol.stack"]restrictions preserved (CLAUDE.md security guidance — frontend / eRPC must not reach the public cloudflared tunnel)release: monitoring,app.kubernetes.io/*) preserved on relocated docskubectl get httproute,middleware,configmap,podmonitor -Amatches before-stateNotes
bedag/rawis still referenced by network helmfiles andinternal/hermes/hermes.go— out of scope for this PR. Theinternal/update/charts.godedup comment is still accurate for those callers.migrateDefaultsHTTPRouteHostnamesinstack.gotargets the old in-helmfile HTTPRoute indentation; it remains a no-op against the relocated templates and the new helmfile, preserved for users upgrading from older stacks.