-
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
namespace ChangeSet; | ||
|
||
//@todo make a cleaner solution? | ||
abstract class Associator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the correct approach. Instead of using inheritance, we can simply build an abstract factory that is able to use class metadata (and eventually a manager registry) to get the correct data. Please keep all this working with stdClass
for now, since that's a point of extension (not meant for this repo)
@liuggio I generally like the changes, but don't try to specialize the factories or make them smarter for now. The demos are supposed to work with only |
totally agree with you I see now the future :) |
@liuggio can you remove the associator stuff then? :) |
Yep! On Wed, Jun 26, 2013 at 5:48 PM, Marco Pivetta notifications@github.comwrote:
liuggio_______________ /|_ We reject kings, presidents and voting. |
Ok |
If you think that Pimple is not necessesary I'll remove it leaving only the repo and the 2 interfaces.. |
public function __construct($object, $compute = false) | ||
{ | ||
$this->object = $object; | ||
|
||
if ($compute) { | ||
$this->snapshot = (array) $this->object; | ||
$this->snapshot = (array)$this->object; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhh, don't change those please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
Little recap:
|
Merging - hopefully going on with this tomorrow (I will try to integrate it with the existing ORM ;) ) |
And obviously: thanks! |
ObjectLoaderFactory
.I
didn'tchange so much, I added an Abstract Repository,a simple Associator for class->worker, and few InterfacesIdentityExtractorFactoryInterfaceObjectLoaderFactoryInterfaceObjectRepositoryFactoryInterfacelet me know what do you think, thanks to the interfaces I created a stupid orm.