Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation PHP 7.4 #484

Closed
wants to merge 1 commit into from

Conversation

@nicolas-grekas
Copy link
Contributor

commented Aug 6, 2019

This PR fixes a deprecation notice that is triggered when the package is used on PHP 7.4.
I'd prefer having this patch on 2.1, but it's not maintained anymore, right? Looks like 2.2 is?
Patch borrowed from #467 so this should reduce merge/cherry-pick conflicts.
Thanks for considering!

@Ocramius

This comment has been minimized.

Copy link
Owner

commented Aug 6, 2019

I already got these fixed in master for 2.5.0. Will likely cut a release from there during the weekend.

@Ocramius

This comment has been minimized.

Copy link
Owner

commented Aug 6, 2019

Ref: #475
Ref: #467
Ref: #465

@Ocramius Ocramius added this to the 2.5.0 milestone Aug 6, 2019

@Ocramius Ocramius self-assigned this Aug 6, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Hum, I see. This one is likely not going to be accepted, isn't it?

@Ocramius

This comment has been minimized.

Copy link
Owner

commented Aug 6, 2019

No, I think people can safely upgrade to 2.5.0, which is fully BC compliant, once I cut it.

I got only a test failure due to a PHPUnit regression, so I held it off, but I'll see if I can fix it while at Froscon.

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

OK, thanks for the feedback, closing then. Happy Froscon :)

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:php74-deprec branch Aug 6, 2019

nicolas-grekas added a commit to symfony/symfony that referenced this pull request Aug 7, 2019

bug #32992 [ProxyManagerBridge] Polyfill for unmaintained version (jd…
…erusse)

This PR was squashed before being merged into the 3.4 branch (closes #32992).

Discussion
----------

[ProxyManagerBridge] Polyfill for unmaintained version

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32844
| License       | MIT
| Doc PR        | NA

The current implementation of proxy-manager triggers a PHP 7.4 deprecation `ReflectionType::__toString`, and the patch won't be applied to a version prior to 2.5 (see Ocramius/ProxyManager#484) will older version of proxy-manager (2.1 to 2.4 are also compatible with php 7.4).

This PR fixes the implementation of `ProxiedMethodReturnExpression` for version prior to 2.5

Commits
-------

33f722d [ProxyManagerBridge] Polyfill for unmaintained version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.