Skip to content

Cache failed registry lookups to avoid hammering APIs #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Cache failed registry lookups to avoid hammering APIs #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/registries/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,19 @@ const cache = require('../utils/cache');
const log = require('../utils/log');
const { prioritiesHost } = require('../utils/url');

const ERR_PACKAGE_NOT_FOUND = 'ERR_PACKAGE_NOT_FOUND';

async function resolve(type, packageName) {
const cacheKey = `${type}_${packageName}`;

const cacheValue = await cache.get(cacheKey);

if (cacheValue) {
return cacheValue;
if (cacheValue !== ERR_PACKAGE_NOT_FOUND) {
return cacheValue;
}

return undefined;
}

const config = registryConfig[type];
Expand All @@ -34,7 +40,9 @@ async function resolve(type, packageName) {
response = await got.get(requestUrl);
} catch (err) {
if (err.statusCode === 404) {
return log('Package not found', packageName, type);
log('Package not found', packageName, type);
await cache.set(cacheKey, ERR_PACKAGE_NOT_FOUND, 900); // 15 minutes
return;
}

return log(err);
Expand All @@ -45,6 +53,7 @@ async function resolve(type, packageName) {
json = JSON.parse(response.body);
} catch (err) {
log('Parsing response failed');
await cache.set(cacheKey, ERR_PACKAGE_NOT_FOUND, 900); // 15 minutes
return;
}

Expand Down Expand Up @@ -94,6 +103,7 @@ async function resolve(type, packageName) {

if (!reachableUrl) {
log('No URL for package found');
await cache.set(cacheKey, ERR_PACKAGE_NOT_FOUND, 900); // 15 minutes
return;
}

Expand Down