Support action workflow run view #1697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbuck
reviewed
Nov 14, 2022
| // When current page is an actions run workflow file | ||
| if (!ret) { | ||
| ret = $( | ||
| '.actions-fullwidth-module .text-small .Link--secondary', |
There was a problem hiding this comment.
Maybe we should switch to https://github.com/refined-github/github-url-detection
Jumpcat.dev is using github-url-detection and it works really well.
There was a problem hiding this comment.
How would that help get the url from this link? The value of it is https://github.com/OctoLinker/OctoLinker/blob/e9e60b630a37e980e48a816e4aaf6355a3fd8707/.github/workflows/ci.yml and it's the only spot on the page with it.
There was a problem hiding this comment.
I shouldn't comment on PRs after midnight 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for linking action workflows in the new actions UI. This is more of a proof of concept, but figured I'd PR it for feedback. Unfortunately there's no other classes or attributes I can see that would let us get this link like we do on the source pages.
Example: https://github.com/OctoLinker/OctoLinker/actions/runs/3457001003/workflow
Checklist: