Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out hidden files, too, like .DS_Store on OSX #9

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

CamDavidsonPilon
Copy link
Contributor

@CamDavidsonPilon CamDavidsonPilon commented Jan 3, 2022

I hit a problem where the customize script was trying to execute a local .DS_Store on my Mac. More generally, users probably don't want hidden files and directories to be executed.

Before

> find workspace/scripts -maxdepth 1 -not -type d
workspace/scripts/11-add-firstboot
workspace/scripts/.DS_Store
workspace/scripts/07-install-logging
workspace/scripts/06-install-pioreactor
workspace/scripts/99-finish
workspace/scripts/12-add-pioreactor-bash-scripts
workspace/scripts/09-install-mosquitto
workspace/scripts/04-install-services
workspace/scripts/08-install-ui
workspace/scripts/01-install-python-and-git
workspace/scripts/10-install-db
workspace/scripts/03-configure-rpi
workspace/scripts/05-install-i2c

After

> find workspace/scripts -maxdepth 1 -not -type d -not -path '*/\.*'
workspace/scripts/11-add-firstboot
workspace/scripts/07-install-logging
workspace/scripts/06-install-pioreactor
workspace/scripts/99-finish
workspace/scripts/12-add-pioreactor-bash-scripts
workspace/scripts/09-install-mosquitto
workspace/scripts/04-install-services
workspace/scripts/08-install-ui
workspace/scripts/01-install-python-and-git
workspace/scripts/10-install-db
workspace/scripts/03-configure-rpi
workspace/scripts/05-install-i2c

@foosel foosel merged commit 23bde85 into OctoPrint:main Jan 3, 2022
@foosel
Copy link
Member

foosel commented Jan 3, 2022

Good point, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants