Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware info not reported to plugins if firmware autodetection is disabled #3456

Closed
foosel opened this issue Feb 18, 2020 · 2 comments
Closed

Firmware info not reported to plugins if firmware autodetection is disabled #3456

foosel opened this issue Feb 18, 2020 · 2 comments

Comments

@foosel
Copy link
Member

@foosel foosel commented Feb 18, 2020

Problem

If firmware autodetection is disabled, firmware information gained from M115 will not be pushed to plugins anymore. It is fine to not evaluate that information actively for serial settings if detection is disabled, however it should still be pushed on the event bus and to plugins.

Solution

Slight logic change. Already fixed in 831edf2.

Additional notes

Not a regression, but considering that it negatively impacts the printer safety plugin that relies on firmware info it'll go into 1.4.0 regardless.

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

@GitIssueBot GitIssueBot commented Feb 26, 2020

This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:

https://community.octoprint.org/t/new-release-candidate-1-4-0rc6/16502/1

@foosel

This comment has been minimized.

Copy link
Member Author

@foosel foosel commented Feb 26, 2020

1.4.0rc6 is out

@foosel foosel closed this Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.