Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printer refuses to connect after setting low latency flag fails #4292

Closed
foosel opened this issue Nov 1, 2021 · 7 comments
Closed

Printer refuses to connect after setting low latency flag fails #4292

foosel opened this issue Nov 1, 2021 · 7 comments
Labels
bug Issue describes a bug done Done but not yet released
Milestone

Comments

@foosel
Copy link
Member

foosel commented Nov 1, 2021

Problem

Since rolling out 1.7.0, there have been a small number of people running into connection issues when setting low latency mode on the serial port fails, e.g. on this thread and also some comments here and there on Discord and elsewhere.

While the error resulting from failing to set the low latency flag itself is gracefully handed, apparently the involved serial ports don't even like the attempt and then no longer work correctly.

Solution

Short term as part of the bug fix release 1.7.1: Turn requesting low latency mode off by default.

Longer term: Maybe close and reopen the port on mode setting failure? That would however require someone who can reproduce the issue to collaborate so possible mitigations can be tested. I currently don't have discovered any system on hand that shows the problematic behaviour and thus can only guess so far.

@foosel foosel added the bug Issue describes a bug label Nov 1, 2021
@foosel foosel added this to the 1.8.0 milestone Nov 1, 2021
@cp2004

This comment has been minimized.

@foosel

This comment has been minimized.

@foosel

This comment has been minimized.

@jneilliii

This comment has been minimized.

@foosel

This comment has been minimized.

@draeath
Copy link

draeath commented Nov 12, 2021

Well, shoot. That was my PR and I feel crappy about it causing people problems :(

@foosel
Copy link
Member Author

foosel commented Dec 2, 2021

I'm going to close this as at least the buggy situation seems to have seem fixed now with not using the low latency flag by default.

Long term I'd still like to find a printer this affected and see I can find a work around to fully recover from a failed attempt automatically so we can default to this again, but until this is the case, this will have to stay off by default 🤷‍♀️

@foosel foosel added the done Done but not yet released label Dec 2, 2021
@foosel foosel modified the milestones: 1.8.0, 1.7.x Dec 2, 2021
@foosel foosel closed this as completed Dec 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue describes a bug done Done but not yet released
Projects
None yet
Development

No branches or pull requests

4 participants