Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Missed dialog for fade in #4164

Merged
merged 1 commit into from Jun 9, 2021

Conversation

cp2004
Copy link
Member

@cp2004 cp2004 commented Jun 9, 2021

Missed the 'reload settings' dialog when sorting out the animations, seems I just missed the one so far in testing

What does this PR do and why is it necessary?

Updates the animation so it is not a stuttering mess

How was it tested? How can it be tested by the reviewer?

Making the dialog open manually using it's selector in the console

Any background context you want to provide?

#4103 & #4085

What are the relevant tickets if any?

Above

Screenshots (if appropriate)

Further notes

Missed the 'reload settings' dialog when sorting out the animations, missed one
@github-actions github-actions bot added the approved Issue has been approved by the bot or manually for further processing label Jun 9, 2021
@foosel foosel merged commit f954377 into OctoPrint:maintenance Jun 9, 2021
@foosel foosel added this to the 1.7.0 milestone Jun 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Issue has been approved by the bot or manually for further processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants