💄 File/Folder move UI improvements #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
targets maintenance
|
confirm makes sense, but you could also make the text change from move to rename when the source folder is the same as destination... |
I actually really like that idea. "Confirm" while valid is less explicit, and a dynamic button title would make things crystal clear here. @cp2004, want to look into that? |
Will do as soon as I get a chance. |
|
Done 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Noticed a couple of small QoL things that I thought I would address with the file/folder moving & renaming.
Missing styling on the name box
fixed
Not obvious you can rename files until after you click the 'scissors' icon. The icon & tooltip don't imply this (see [Request] Please allow to rename jobs (gcode files) and "star" those to keep. #4693) to the average user perhaps?
Made it more obvious.
No distinction between moving files or folders. The title says 'Move file or folder', the name just says 'filename' (but applies to folder names as well) & text at the bottom says 'file/folder will be moved to'. Just got on my nerves when I looked at it 😆
Made it show the correct name
Text at the bottom 'File/Folder will be moved to' is visible even when there is no action to be performed.
Made it disappear when nothing will happen
Button says 'Move', while file moving & renaming are the same in the code, I thought it made more sense for this to be 'confirm'. Up for debate on that one I guess, just sounded better to me personally.
Made it confirm
How was it tested? How can it be tested by the reviewer?
Locally on my development install by moving a folder or file.
Any background context you want to provide?
Inspired by #4693 being opened