Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding UI breaks when variable filtering used in variables or bound variables #1193

Closed
vanessalove opened this issue Sep 9, 2014 · 9 comments

Comments

@vanessalove
Copy link
Contributor

commented Sep 9, 2014

Using #{Environment | ToLower} as a bound variable inside the hostname of IIS bindings breaks the UI

Source: http://help.octopusdeploy.com/discussions/problems/24512

@vanessalove vanessalove added the kind/bug label Sep 9, 2014
@vanessalove vanessalove added this to the 2.5.9 milestone Sep 9, 2014
@PaulStovell PaulStovell modified the milestones: 2.5.9, 2.5.11 Oct 7, 2014
@daniellittledev daniellittledev added 1 - Ready and removed 1 - Ready labels Oct 9, 2014
@DamianMac DamianMac modified the milestones: 2.5.11, Coming Up Oct 15, 2014
@DamianMac DamianMac modified the milestones: 2.5.11, Coming Up Oct 15, 2014
@PaulStovell PaulStovell modified the milestones: 3.0, 2.5.11 Oct 15, 2014
@PaulStovell PaulStovell added 0 - Backlog and removed 3 - Working labels Oct 15, 2014
@PaulStovell

This comment has been minimized.

Copy link
Member

commented Nov 12, 2014

Fixed already

@PaulStovell PaulStovell removed this from the 3.0 milestone Nov 12, 2014
@AlexRetzlaff

This comment has been minimized.

Copy link

commented Feb 4, 2015

Thanks guys!

@DmitryLobanov

This comment has been minimized.

Copy link

commented Feb 12, 2015

Not fixed :( We have hit it on 2.6.0 just today. What are we doing wrong? (we are using this when referencing one variable from another).

Here's what I see in verbose log when variables detailed log is enabled:

[some vars list]
Variables have been fully evaluated.
The following evaluated variables are available:
[some vars list]
- [Deploy.Instance] = 'V2Dev'
- [IIS.AppPoolName] = 'xxx_#{Deploy.Instance | ToLower}'
- [IIS.SiteName] = 'xxx_#{Deploy.Instance | ToLower}'

Removing '.' from referenced variable (Deploy.Instance => DeployInstance) doesn't fix the thing.

@vanessalove

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2015

I can confirm that when you use a bound variable, it does not work in the bindings. I get a powershell error because the variable never expands.

@vanessalove vanessalove reopened this Feb 19, 2015
@drusellers

This comment has been minimized.

Copy link

commented Mar 11, 2015

I have experienced this issue as well. Watching. :)

@PaulStovell

This comment has been minimized.

Copy link
Member

commented Apr 16, 2015

Using these filters should now work in 3.0. Need to test whether the |'s cause the before script to fail though.

@PaulStovell PaulStovell added this to the 3.0-pre1 milestone Apr 16, 2015
@drusellers

This comment has been minimized.

Copy link

commented Apr 17, 2015

yay

@PaulStovell PaulStovell modified the milestones: 3.0-pre2, 3.0-pre1 May 5, 2015
@Damovisa

This comment has been minimized.

Copy link

commented May 25, 2015

Tested on 3.0 and this now works correctly.

@Damovisa Damovisa closed this May 25, 2015
@Damovisa Damovisa added 3 - Done and removed 1 - In Sprint labels May 25, 2015
@PaulStovell PaulStovell modified the milestones: 3.0, 3.0-public-beta May 26, 2015
@PaulStovell PaulStovell removed the 3 - Done label May 26, 2015
@lock

This comment has been minimized.

Copy link

commented Nov 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
8 participants
You can’t perform that action at this time.