Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client not closed properly for sending a second email #1609

Closed
vanessalove opened this issue May 22, 2015 · 3 comments

Comments

@vanessalove
Copy link
Contributor

commented May 22, 2015

If you have two email steps in a project process the second mostly errors with:

Failure sending mail.
System.Net.Mail.SmtpException: Failure sending mail. ---> System.IO.IOException: Unable to read data from the transport connection: net_io_connectionclosed.
at System.Net.Mail.SmtpReplyReaderFactory.ProcessRead(Byte[] buffer, Int32 offset, Int32 read, Boolean readLine) at System.Net.Mail.SmtpReplyReaderFactory.ReadLines(SmtpReplyReader caller, Boolean oneLine) at System.Net.Mail.SmtpReplyReaderFactory.ReadLine(SmtpReplyReader caller) at System.Net.Mail.CheckCommand.Send(SmtpConnection conn, String& response) at System.Net.Mail.SmtpTransport.SendMail(MailAddress sender, MailAddressCollection recipients, String deliveryNotify, Boolean allowUnicode, SmtpFailedRecipientException& exception) at System.Net.Mail.SmtpClient.Send(MailMessage message) --- End of inner exception stack trace --- at System.Net.Mail.SmtpClient.Send(MailMessage message) at Octopus.Server.Orchestration.Deploy.Email.EmailActionOrchestrator.d__0.MoveNext() in y:\work\refs\heads\master\source\Octopus.Server\Orchestration\Deploy\Email\EmailActionOrchestrator.cs:line 53 Octopus.Server version 2.6.5.1010
Fatal 14:17:53
The step failed

Henrik found this: http://stackoverflow.com/a/5832192

Source: http://help.octopusdeploy.com/discussions/problems/34308

@bova80

This comment has been minimized.

Copy link

commented May 22, 2015

This is the most common error we get on the email step. It would be nice if it either retried or if the email step fails the entire deployment isn't marked as failed. This often happens to us with just one email step in the deployment.

@PaulStovell PaulStovell added this to the 3.1 milestone May 26, 2015
@PaulStovell PaulStovell modified the milestones: 3.1, 3.0.2 Jul 17, 2015
@PaulStovell PaulStovell added the ready label Jul 22, 2015
@PaulStovell PaulStovell modified the milestones: 3.0.3, 3.0.2, 3.0.4 Jul 22, 2015
@zentron zentron self-assigned this Jul 22, 2015
@zentron zentron added in progress and removed ready labels Jul 22, 2015
@zentron

This comment has been minimized.

Copy link

commented Jul 22, 2015

The disposal logic should fix this problem if it is due to the issue noted in http://stackoverflow.com/questions/1143846/unable-to-read-data-from-the-transport-connection-net-io-connectionclosed/5832192#5832192
regarding a failure to properly send QUIT command.
The retry functionality will be covered by #1666

@zentron zentron closed this Jul 22, 2015
@zentron zentron removed the in progress label Jul 22, 2015
@lock

This comment has been minimized.

Copy link

commented Nov 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.