Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Calamari Delete/Copy operations appear to be failing silently #1960

Closed
michaelnoonan opened this issue Sep 1, 2015 · 5 comments
Closed
Assignees
Labels
feature/calamari kind/bug This issue represents a verified problem we are committed to solving priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible
Milestone

Comments

@michaelnoonan
Copy link
Contributor

When using a Custom Installation Directory and Purging it as part of the deployment, the deployment appears to succeed but the files are not actually deployed. Loading the Verbose logs reveals:

  1. The Purge operation succeeded immediately
  2. The copy operation retried each file for 1 minute before moving on to the next file, but the files weren't actually copied, and there is no log of any error.

The log file attached to the source help ticket is the best source for information.

Source: http://help.octopusdeploy.com/discussions/problems/38341-octopus-deploy-not-deploying-files

Most likely candidate is http://blogs.msdn.com/b/dotnet/archive/2015/07/28/ryujit-bug-advisory-in-the-net-framework-4-6.aspx

One consideration would be to disable RyuJIT: https://github.com/Microsoft/dotnet/blob/master/docs/testing-with-ryujit.md#disable-ryujit

Alternatively we could [MethodImplAttribute(MethodImplOptions.NoOptimization)] the offending methods.

Otherwise we need our Customers to update .NET 4.6 to mitigate this issue.

@michaelnoonan michaelnoonan added kind/bug This issue represents a verified problem we are committed to solving priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible feature/calamari this-week labels Sep 1, 2015
@michaelnoonan
Copy link
Contributor Author

@michaelnoonan
Copy link
Contributor Author

@MJRichardson
Copy link

I have done the following:

  • Corrected retry logic so exception eventually gets thrown.
  • Improved logging when retrying (so exception message is included).
  • Attempt to ensure deletion of directory occurs before we proceed to re-create the directory.

@MJRichardson MJRichardson added this to the 3.0.21 milestone Sep 2, 2015
@MJRichardson
Copy link

release note: Improved handling for missing bin directory issue when copying to custom installation directory.

@lock
Copy link

lock bot commented Nov 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/calamari kind/bug This issue represents a verified problem we are committed to solving priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants