Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed health check icons are incorrect #2018

Closed
tothegills opened this issue Sep 22, 2015 · 7 comments

Comments

@tothegills
Copy link

commented Sep 22, 2015

If a health check fails, the icon displayed is a green tick instead of a red cross. Also heard of this issue happening with Tentacle update.

@tothegills tothegills added the kind/bug label Sep 22, 2015
@tothegills

This comment has been minimized.

Copy link
Author

commented Sep 22, 2015

image

@DamianMac DamianMac added the ready label Oct 28, 2015
@zentron zentron added in progress and removed ready labels Nov 6, 2015
@zentron zentron self-assigned this Nov 6, 2015
@zentron zentron added this to the 3.2.2 milestone Nov 6, 2015
@zentron

This comment has been minimized.

Copy link

commented Nov 6, 2015

Release Note: Tasks with error messages cause parent tasks/nodes to also be in a error state.

@zentron zentron closed this Nov 8, 2015
@zentron zentron removed the in progress label Nov 8, 2015
@zentron

This comment has been minimized.

Copy link

commented Nov 10, 2015

This appears to be by design as evident by unit test ActivityLogTreeNodeFixture.ShouldBuildTree although seems a little odd.
As a result this change is being temporarily reverted in https://github.com/OctopusDeploy/OctopusDeploy/commit/0838ef16c8883fb7bc8520df5cb69554e978ae04

@zentron zentron removed this from the 3.2.2 milestone Nov 10, 2015
@zentron zentron reopened this Nov 10, 2015
@zentron zentron added the in progress label Nov 10, 2015
@PaulStovell

This comment has been minimized.

Copy link
Member

commented Nov 11, 2015

Looks like a bug (I'm pretty sure it worked before). The machines that fail should be red. The overall task will still be green since the health check "passed" (some machines were just unavailable as is sometimes expected).

@zentron

This comment has been minimized.

Copy link

commented Nov 12, 2015

Just a note that 3.0.24 had related bug
image

@zentron zentron added forreview and removed in progress labels Nov 12, 2015
@zentron zentron closed this Nov 16, 2015
@zentron zentron removed the forreview label Nov 16, 2015
@zentron zentron added this to the 3.2.4 milestone Nov 16, 2015
@lock

This comment has been minimized.

Copy link

commented Nov 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.