Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server consistently crashes when creating a release using a custom step template with a rather odd variable usage #2057

Closed
Dalmirog opened this issue Oct 8, 2015 · 6 comments

Comments

@Dalmirog
Copy link

commented Oct 8, 2015

Repro steps are a bit long, so please check the ticket below and update this Issue's subject and body to something more meaningful.

I was able to reproduce this in 2 separate Octopus instances.

Source: https://secure.helpscout.net/conversation/126278635/1963/?folderId=557082
Octopus version: 3.1.3

@michaelnoonan

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2015

Related to #1915

@hnrkndrssn hnrkndrssn self-assigned this Nov 18, 2015
@hnrkndrssn hnrkndrssn added in progress and removed ready labels Nov 18, 2015
@hnrkndrssn

This comment has been minimized.

Copy link

commented Nov 18, 2015

Root cause is that the variable name in the step template is NuGetPackageId, this field is then using an expression of #{NuGetPackageId} which Octostache then tries to evaluate by finding the value of the variable NuGetPackageId, which in this case causes an infinite recursion and ends in 😭 💥 (aka StackOverflowException)

@hnrkndrssn hnrkndrssn removed their assignment Nov 19, 2015
@hnrkndrssn hnrkndrssn added ready and removed in progress labels Nov 19, 2015
@hnrkndrssn

This comment has been minimized.

Copy link

commented Nov 19, 2015

@zentron zentron added in progress and removed ready labels Nov 19, 2015
@zentron zentron self-assigned this Nov 19, 2015
@zentron zentron added ready and removed in progress labels Nov 19, 2015
@zentron

This comment has been minimized.

Copy link

commented Nov 19, 2015

Fixed By: OctopusDeploy/Octostache@8adf836 & OctopusDeploy/OctopusDeploy@2277775
An exception will now be thrown if, during variable parsing, a reference loop is discovered. While this means an exception will still occur, the message should provide some context and it shouldn't kill the server with a StackOverflowException

@zentron zentron added this to the 3.2.4 milestone Nov 19, 2015
@zentron

This comment has been minimized.

Copy link

commented Nov 19, 2015

Release Note: InvalidOperationException thrown to prevent service crash if variable parsing discovers a self referencing loop .

@zentron zentron closed this Nov 19, 2015
@zentron zentron removed the in progress label Nov 19, 2015
@lock

This comment has been minimized.

Copy link

commented Nov 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.