Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider retrying the final DeploymentPlan persistence step #2109

Closed
michaelnoonan opened this issue Nov 2, 2015 · 2 comments

Comments

@michaelnoonan
Copy link
Contributor

commented Nov 2, 2015

A deployment can completely succeed, but a SQL Timeout in DeploymentPlanService.Persist() leaves the deployment in a failed state that cannot be rectified by the user.

It would make sense if the DeploymentPlanService.Persist() and DeploymentPlanService.Cleanup() methods were retried since they would be idempotent.

Source: http://help.octopusdeploy.com/discussions/problems/41421-error-while-executing-sql-command-timeout-expired

@michaelnoonan michaelnoonan added the ready label Nov 16, 2015
@zentron zentron self-assigned this Nov 16, 2015
@zentron zentron added in progress and removed ready labels Nov 16, 2015
@zentron

This comment has been minimized.

Copy link

commented Nov 18, 2015

Release Note: Recording the final state of a Deployment is now more tolerant of transient faults

@zentron zentron added this to the 3.2.4 milestone Nov 18, 2015
@zentron zentron closed this Nov 18, 2015
@zentron zentron removed the in progress label Nov 18, 2015
@lock

This comment has been minimized.

Copy link

commented Nov 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.