Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually skipped steps should also be skipped during auto-deploy #2861

Closed
michaelnoonan opened this issue Oct 28, 2016 · 4 comments
Closed
Assignees
Labels
feature/elastictransientenvironments kind/bug This issue represents a verified problem we are committed to solving priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible
Milestone

Comments

@michaelnoonan
Copy link
Contributor

michaelnoonan commented Oct 28, 2016

Steps that are skipped as part of a manual deployment of a project should also be skipped when running an automatic deployment of the project.

At the moment we forget the steps that were skipped in the manual deployment, and attempt to run ALL steps during an automatic deployment. We think this would lead to unexpected results...

Auto-deployments are intended to "make a new machine just like the other machines" - like auto scaling a web farm. If certain steps were skipped to the existing machines during a manual deployment, we should also skip the same steps when automatically deploying to a new machine so it has the best possible chance of ending up just like its counterparts.

@michaelnoonan michaelnoonan added kind/bug This issue represents a verified problem we are committed to solving priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible release/3.4 feature/elastictransientenvironments labels Oct 28, 2016
@octoreleasebot octoreleasebot added this to the 3.4.15 milestone Oct 31, 2016
@octoreleasebot
Copy link

Release Note: Steps that were manually skipped during a deployment will also be skipped during subsequent automatic deployments

@JesseNaranjo
Copy link

Does this apply only within the same Release?

For example - I create Release 1.0.50 and skip step 5. Will creating Release 1.0.51 (whether manually or automatically) auto-skip step 5 too?

@matt-richardson
Copy link
Contributor

Hi @JesseNaranjo

The base premise for the auto-deploy is to bring all machines into the same state, so in your example, it will only skip step 5 when auto-deploying 1.0.50.

If you create 1.0.51, and deploy it without skipping any steps, it will not auto-skip any steps.

There's some pretty comprehensive docs on automatic deployment triggers, so feel free to take a look for further info.

@lock
Copy link

lock bot commented Nov 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/elastictransientenvironments kind/bug This issue represents a verified problem we are committed to solving priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible
Projects
None yet
Development

No branches or pull requests

5 participants