Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warning or error if CustomInstallationDirectory is a subdirectory of the original extraction location #2927

Closed
zentron opened this issue Nov 17, 2016 · 2 comments

Comments

@zentron
Copy link

commented Nov 17, 2016

If the user provides a CustomInstallationDirectory that corresponds to a subdirectory of the original extraction location, the directory contents get copied deeper and deeper (since the new "custom" directory gets created in the original location, then inside itself ad infinitum) resulting in either PathTooLong or FileInUse exceptions.
image

A error should be thrown at the start if it appears that the custom location is a sub directory (or the same directory) of the initial installation location.

Reference: http://help.octopusdeploy.com/discussions/problems/48931

@zentron zentron changed the title Log warning if CustomInstallationDirectory is a subdirectory of the original extraction location Log warning or error if CustomInstallationDirectory is a subdirectory of the original extraction location Nov 17, 2016
@markryd markryd self-assigned this Feb 13, 2017
@markryd markryd closed this Feb 14, 2017
@octoreleasebot octoreleasebot added this to the 3.9.1 milestone Feb 14, 2017
@octoreleasebot

This comment has been minimized.

Copy link

commented Feb 14, 2017

Release Note: Prevent deploying to a custom directory that is a child of the default extraction path

@tothegills tothegills modified the milestones: 3.10.0, 3.9.1 Feb 15, 2017
@lock

This comment has been minimized.

Copy link

commented Nov 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot unassigned markryd Nov 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.