Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription event payloads include shortened links that are invalid routes in the web UI #3109

Closed
hnrkndrssn opened this issue Jan 27, 2017 · 6 comments
Assignees
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Milestone

Comments

@hnrkndrssn
Copy link

Currently event payloads in subscriptions have links to each event as /r/DocID which is not going to resolve to the proper location when used. We should look at implementing a similar approach as our octo_directory service in Angular which translates the links to their proper routes.

Source: http://help.octopusdeploy.com/discussions/questions/10251

@hnrkndrssn hnrkndrssn added the kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time label Jan 27, 2017
@hnrkndrssn
Copy link
Author

@graemechristie
Copy link

Looks like this is still not implemented. Can we get an update on the status of this ?

@hnrkndrssn
Copy link
Author

Hi @graemechristie,

I will be picking this issue up in the next day or so and it should be ready to be released in the near future.

Thanks,
Henrik

@hnrkndrssn hnrkndrssn self-assigned this Apr 18, 2017
@jdkang
Copy link

jdkang commented Apr 18, 2017

If the subscription payloads are being tweaked, I'm wondering if there is another enhancement for consumption with "zero knowledge" (i.e. API calls).

Currently, RelatedDocumentIds aren't hydrated. I'm wondering if this could be turned into a class property -- e.g. { Id = "Projects-1234", Name = "OcotoFx"} -- as well as the addition of ProjectGroup (which we routinely use for internal API-driven scripts).

I realize the Subscription system supports pre-webhook filtering, but sometimes it's easier to filter/sort on the consumption end. There are no "Not $x" filtering rules in the subscription interface.

@octoreleasebot octoreleasebot added this to the 3.12.7 milestone Apr 20, 2017
@octoreleasebot
Copy link

Release Note: Links in subscription event payloads are now fully qualified relative paths into the Octopus web UI. If you have been using the previous format /r/ResourceID and are parsing them, you no longer need to do this parsing

@lock
Copy link

lock bot commented Nov 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Development

No branches or pull requests

5 participants