Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tables and other formatting in markdown to HTML converter #3123

Closed
Dalmirog opened this issue Feb 1, 2017 · 3 comments
Closed

Support tables and other formatting in markdown to HTML converter #3123

Dalmirog opened this issue Feb 1, 2017 · 3 comments
Milestone

Comments

@Dalmirog
Copy link

@Dalmirog Dalmirog commented Feb 1, 2017

Regression from #2819

Things like Italic , Bold and Link work OK, but tables are still not quite there.

Markdown used for testing:

Artist Record Link
Bill Callahan Apocalypse Youtube
Nick Drake Pink Moon Spotify

Raw HTML received

<p>|Artist|Record|Link|
|---|---|---|
|<strong>Bill Callahan</strong>|<em>Apocalypse</em>|<a href="https://www.youtube.com/watch?v=n3ebEN4PeC8&amp;t=1899s">Youtube</a>|
|<strong>Nick Drake</strong>|<em>Pink Moon</em>|<a href="https://open.spotify.com/album/6LoD5uGEynY4eqstWDFKhg">Spotify</a>|</p>

Source: http://help.octopusdeploy.com/discussions/questions/10640-how-to-include-release-notes-in-markdown-to-emails-sent-by-octopus
Octopus: 3.8.4

@Dalmirog Dalmirog changed the title Support tables and other formatting in markdown - Take 2 Support tables and other formatting in markdown to HTML converter Feb 1, 2017
@markryd

This comment has been minimized.

Copy link

@markryd markryd commented Feb 2, 2017

The .net markdown library we use doesn't support tables (which aren't part of the Markdown spec, not that there really is a spec). It works in some places because our .js Markdown library does support tables.

We're going to swap to a new lib so that things are a little more consistent.

@markryd markryd self-assigned this Feb 2, 2017
@markryd markryd closed this Feb 2, 2017
@octoreleasebot

This comment has been minimized.

Copy link

@octoreleasebot octoreleasebot commented Feb 2, 2017

Release Note: Added table support to the Markdown filter in variable replacement

@lock

This comment has been minimized.

Copy link

@lock lock bot commented Nov 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot unassigned markryd Nov 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.