Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompted empty variable incorrectly falls back to default value #3560

Closed
MarkSiedle opened this issue Jun 13, 2017 · 2 comments
Closed

Prompted empty variable incorrectly falls back to default value #3560

MarkSiedle opened this issue Jun 13, 2017 · 2 comments
Assignees
Labels
kind/bug This issue represents a verified problem we are committed to solving
Milestone

Comments

@MarkSiedle
Copy link

If you have a prompted variable in your project variables (not mandatory) with a default value, then you create a release and specifically clear the default value (making it blank), during the deployment the variable falls back to the default value.

Since the user has specifically cleared the value at the point of creating the release, we should honour that decision and use the empty value.

After discussions with the team, this "treat blank/empty to mean not set, so fallback to default" is probably used in quite a few places and we need to be consistent across the board. Whoever picks up this ticket, please consider reviewing the codebase for other areas where this same variable fallback behaviour may need to be reviewed, and make them all consistent.

We should use null checking here (if possible) to determine whether we fallback to the default value or not.

Eg. If null, then fallback to the default value, else use whatever the variable is set to (even if that is an empty string).

Source: https://secure.helpscout.net/conversation/379801418/16299/?folderId=801354

@MarkSiedle MarkSiedle added area/execution kind/bug This issue represents a verified problem we are committed to solving labels Jun 13, 2017
@tothegills tothegills self-assigned this Sep 11, 2017
@octoreleasebot octoreleasebot added this to the 3.17.2 milestone Sep 17, 2017
@octoreleasebot
Copy link

Release Note: Empty string may now be provided to override the default value of optional prompted variables

@lock
Copy link

lock bot commented Nov 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

3 participants