Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate private keys downloadable when guest user has admin rights #3869

Closed
michaelnoonan opened this issue Oct 18, 2017 · 2 comments
Closed
Assignees
Labels
priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible
Milestone

Comments

@michaelnoonan
Copy link
Contributor

michaelnoonan commented Oct 18, 2017

Issue

See private issue: https://github.com/OctopusDeploy/OctopusDeploy/issues/1282

CVE-2017-15610

When the special Guest user account is granted the CertificateExportPrivateKey permission, and Guest Access is enabled for the Octopus Server, an attacker can sign in as the Guest account and export Certificates managed by Octopus, including the private key.

We generally recommend the Guest account is not granted these high-level permissions, but want to take the extra step to ensure private keys are never leaked to the Guest user account.

Affected Versions

Octopus 3.11.0 to 3.17.6. Fixed in Octopus 3.17.7.

Implemented Solution

The special Guest account is specifically denied access to export certificates including the private key, even if the Guest account has been granted the CertificateExportPrivateKey permission.

Fixed in https://github.com/OctopusDeploy/OctopusDeploy/pull/1384

@michaelnoonan michaelnoonan added the priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible label Oct 18, 2017
@michaelnoonan michaelnoonan added this to the 3.17.7 milestone Oct 18, 2017
@michaelnoonan michaelnoonan self-assigned this Oct 18, 2017
@michaelnoonan
Copy link
Contributor Author

Release Notes: The special Guest account is now denied access to certificate private keys, even if that user has been granted the CertificateExportPrivateKey permission

@lock
Copy link

lock bot commented Nov 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant