Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step Template Name XSS Vulnerability #3915

Closed
michaelnoonan opened this issue Nov 13, 2017 · 2 comments
Closed

Step Template Name XSS Vulnerability #3915

michaelnoonan opened this issue Nov 13, 2017 · 2 comments
Assignees
@michaelnoonan
Labels
priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible
Milestone
3.17.14

Comments

@michaelnoonan
Copy link
Contributor

michaelnoonan commented Nov 13, 2017 •
edited
Loading

There is a XSS vulnerability in the step template name, when either importing or adding a custom step template.

Refer to: https://secure.helpscout.net/conversation/465740876?folderId=557080

Also see: https://github.com/OctopusDeploy/OctopusDeploy/issues/1463

Fixed by https://github.com/OctopusDeploy/OctopusDeploy/commit/582e2b1203ecda0df06e121f68db11ee20ee583d

CVE-2017-16801
@michaelnoonan michaelnoonan added the priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible label Nov 13, 2017
@michaelnoonan michaelnoonan added this to the 3.17.14 milestone Nov 13, 2017
@michaelnoonan michaelnoonan self-assigned this Nov 13, 2017
@michaelnoonan
Copy link
Contributor Author

Release Note: Fixed a XSS vulnerability with the Step Template Name

@lock
Copy link

lock bot commented Nov 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaelnoonan michaelnoonan

Labels
priority (obsolete) This issue has been recognised as a priority and should be addressed as soon as possible
Projects
None yet
Milestone
3.17.14
Development

No branches or pull requests
1 participant
@michaelnoonan