New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering by machine ids in machine API endpoints #4053

Closed
hnrkndrssn opened this Issue Dec 8, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@hnrkndrssn

hnrkndrssn commented Dec 8, 2017

Currently we allow passing in an ids query parameter to ~/api/machines/ and ~/api/machines/all but we never use it when applying the filtering in the API, we should do this.

@DennisDyallo

This comment has been minimized.

Show comment
Hide comment
@DennisDyallo

DennisDyallo Dec 11, 2017

Would it not be better just to populate a new "Machine Hostnames List" variable inside of Octopus?? Or atleast be able to get it without creating a new API client in power shell. I would prefer it to be a build in Octopus Powershell cmdlet

DennisDyallo commented Dec 11, 2017

Would it not be better just to populate a new "Machine Hostnames List" variable inside of Octopus?? Or atleast be able to get it without creating a new API client in power shell. I would prefer it to be a build in Octopus Powershell cmdlet

@hnrkndrssn

This comment has been minimized.

Show comment
Hide comment
@hnrkndrssn

hnrkndrssn Dec 11, 2017

@DennisDyallo after having a chat with the team, we have decided that we will add a new variable that will contain the machine names as well. (I had a vague recollection that we didn't do this for a reason, but I have not been able to find said reason.)

hnrkndrssn commented Dec 11, 2017

@DennisDyallo after having a chat with the team, we have decided that we will add a new variable that will contain the machine names as well. (I had a vague recollection that we didn't do this for a reason, but I have not been able to find said reason.)

@hnrkndrssn hnrkndrssn closed this Dec 12, 2017

@octoreleasebot octoreleasebot added this to the 4.1.3 milestone Dec 12, 2017

@octoreleasebot

This comment has been minimized.

Show comment
Hide comment
@octoreleasebot

octoreleasebot Dec 12, 2017

Release Note: /api/machines and /api/machines/all API endpoints now allows filtering by machine IDs by way of the querstring ids passed in as a comma-separated list of IDs or specified multiple times

octoreleasebot commented Dec 12, 2017

Release Note: /api/machines and /api/machines/all API endpoints now allows filtering by machine IDs by way of the querstring ids passed in as a comma-separated list of IDs or specified multiple times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment