Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate variables in package names during Auto Release Creation and Scheduled Triggers #4236

Closed
mayuanyang opened this issue Feb 5, 2018 · 7 comments

Comments

@mayuanyang
Copy link

commented Feb 5, 2018

ARC is not working if a project with multiple package steps and one of them with bound package ID, even thought that the ARC trigger is setup to the step that without bound package Id.

If that is the expected behavior, we should consider having a validation/warning message when setting up the trigger, without that it is not easy to reason what went wrong

Steps to reproduce

  • Setup a project with 2 package steps
  • First one's package Id is bound, second one set to a normal package ID
  • Setup a ARC on the package from the second step
  • Upload a package for step two
  • No release is automatically created
@mayuanyang

This comment has been minimized.

Copy link
Author

commented Feb 8, 2018

@droyad droyad changed the title Auto Release Creation is not working when if there is one step with bound package ID Evaluate variables in package names during Auto Release Creation Feb 8, 2018
@droyad

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

+1 from a user on Slack

@droyad droyad self-assigned this Mar 19, 2019
@droyad droyad changed the title Evaluate variables in package names during Auto Release Creation Evaluate variables in package names during Auto Release Creation and Scheduled Triggers Mar 21, 2019
@droyad

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

The same limitation applies to scheduled triggers

@droyad

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

@droyad droyad closed this Apr 2, 2019
@octoreleasebot octoreleasebot added this to the 2019.4.0 milestone Apr 2, 2019
@octoreleasebot

This comment has been minimized.

Copy link

commented Apr 2, 2019

Release Note: Auto Release Creation and Scheduled Triggers now evaluate variables in package names

@lock

This comment has been minimized.

Copy link

commented Jul 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.