Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy release should not be a child step #4286

Closed
markryd opened this issue Feb 15, 2018 · 2 comments
Closed

Deploy release should not be a child step #4286

markryd opened this issue Feb 15, 2018 · 2 comments
Assignees
Labels
kind/bug This issue represents a verified problem we are committed to solving
Milestone

Comments

@markryd
Copy link

markryd commented Feb 15, 2018

We don't prevent deploy release steps being child steps. At the moment this crashes because the step doesn't implement ITargetActionHandler. That would be easy enough to do, but not in a meaningful way. That implies you accept a Machine, and Deploy Release can't do anything with a machine or role, it can only deploy a release. It doesn't make sense to say "Deploy this release to this role" as all the role information is down on the project you are deploying.

We'll block users making them child steps instead.

@markryd markryd added kind/bug This issue represents a verified problem we are committed to solving area/execution labels Feb 15, 2018
@markryd markryd self-assigned this Feb 15, 2018
@markryd markryd closed this as completed Feb 15, 2018
@markryd markryd added this to the 2018.2.4 milestone Feb 15, 2018
@markryd
Copy link
Author

markryd commented Feb 15, 2018

Release Note: Prevent the deploy release step from being added as a child step

@lock
Copy link

lock bot commented Nov 23, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

1 participant