Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built in worker doesn't handle usernames in machinename\username format #4302

Closed
matt-richardson opened this issue Feb 19, 2018 · 2 comments

Comments

@matt-richardson
Copy link
Contributor

commented Feb 19, 2018

If you try and configure the built in worker with a username in machinename\username format, it doesn't work very well:

  • in the UI, it formats the the user badly - it shows up as machinename\machinename\username. [The code] assumes that this value will always be passed via the --domain parameter and if its not, then just prefix with the machine name
  • the test functionality fails, and therefore the service cant start:
Testing the built-in worker configuration.
Built-in worker: FAILED.
These detailed test logs should help figure out what is going wrong, and how to fix the problem.
The success of this configuration depends on both the source and target user accounts.
Current User: NT AUTHORITY\SYSTEM
Target User: WIN-EESBIMGIPO2\WIN-EESBIMGIPO2\OctoUser

Step 1: Testing credentials... FAILED We couldn't get an impersonation token for that user with those credentials. 

Potential Solutions

  • validate for an machine\user format, and prevent it (telling its not necessary for local users, and they should use the --domain parameter if they need to use a non local account)
  • detect if its got a \ in it
    • if domain is also supplied, error
    • if domain is not supplied
      • if the prefix is . or the local machine name, ignore it
      • else set domain to the part before the slash
@octoreleasebot

This comment has been minimized.

Copy link

commented Oct 22, 2018

Release Note: The built-in worker command-line interface handles machine\user and domain\user formats more gracefully

@lock

This comment has been minimized.

Copy link

commented Jan 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.