Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues when choosing a tag with a large number of tenants on the create deployment screen. #4415

Closed
Flamage82 opened this issue Mar 23, 2018 · 5 comments
Assignees
Labels
feature/performance kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Milestone

Comments

@Flamage82
Copy link

When selecting a tag on the create deployment screen, the tag is resolved to a list of tenants, and then we query the server 4 times for each tenant. This amounts to 1600 requests for a tag with 200 tenants, when you include OPTIONS requests.

I propose to allow a tag to be passed directly to the API in these circumstances, which would reduce the number of calls to 4 for a single tag.

@Flamage82 Flamage82 added kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time feature/performance labels Mar 23, 2018
@Flamage82 Flamage82 self-assigned this Mar 23, 2018
@adamwhitekallidus
Copy link

Any idea when this bug will be fixed? We are adding new tenants all the time and each one is making the performance worse and worse!

@Flamage82
Copy link
Author

@adamwhitekallidus Sorry about the delay. Things have been a little hectic, and I've been unable to complete a fix for this issue yet. @johnsimons has kindly offered to take over this task and hopefully we will have something for you soon.

@johnsimons johnsimons assigned johnsimons and unassigned Flamage82 May 10, 2018
@johnsimons johnsimons added this to the 2018.4.13 milestone May 10, 2018
@johnsimons
Copy link

Release Note: Improvements for when choosing a tag with a large number of tenants on the create deployment screen

@michaelnoonan
Copy link
Contributor

This change caused a DOA for 2018.5.0. We have reopened the issue to be addressed in a later patch. The regression was fixed by #4556

@lock
Copy link

lock bot commented Nov 23, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/performance kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Development

No branches or pull requests

5 participants