Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Update Variables snapshot #4700

Closed
MarkSiedle opened this issue Jul 5, 2018 · 5 comments
Assignees
Milestone

Comments

@MarkSiedle
Copy link

@MarkSiedle MarkSiedle commented Jul 5, 2018

We need to address a few pain points on the release screens around the variable snapshot:

  • Improve visibility of the "Update Variables" action for a release, so users can more easily access this button (without having to show/hide the variables).
  • Improve the messaging of the variable snapshot warning, so we give you an indication about WHY you're seeing this warning (I.e. what flag(s) are causing you to see the warning) and we customise the warning message depending on the flags now, so you don't see a message saying "you can update your variables here" when it's actually changes to your deployment process that caused the warning (I.e. NOTHING TO DO WITH VARIABLES >< ... and vice versa).
  • Include links to the Audit screen so ppl can see what changed when they see this changed warning
  • Add an Update Variables overflow menu to the release screen, since this is an action directly related to a release, and if you have a complex lifecycle or packages, the variable snapshot section is below the fold and hard to find without scrolling, so this gives people multiple options to more easily update their variables.
  • Fix a long-time dirty state bug, where you constantly see the "dirty state, something has changed!" dialog even you've just landed on the release screen (this was occurring because we were hacking the FormPaperLayout to enable the primary action based on dirty state) ... now we've got properties on the FormPaperLayout that will let us customise it in these custom situations, where we just wanna say "Enable the form action if I can deploy"). <- This one will need the most testing to make sure we haven't screwed something up
  • Improve visibility of diffs in the audit screen by making the background white, so diffs can stand out better.
  • Also adds an audit trail overflow menu to the project overview page, so ppl with permission can more easily get to the audit trail for a project (requested in community slack).

Update Variables action

2018-07-05 13_01_43-releases _ release 0 0 40 - octopus deploy

Messaging updates

screen shot 2018-07-06 at 4 19 44 pm

Auditing updates

screen shot 2018-07-05 at 1 01 05 pm

@MarkSiedle MarkSiedle self-assigned this Jul 5, 2018
@MarkSiedle MarkSiedle closed this Jul 9, 2018
@octoreleasebot octoreleasebot added this to the 2018.6.15 milestone Jul 9, 2018
@octoreleasebot

This comment has been minimized.

Copy link

@octoreleasebot octoreleasebot commented Jul 9, 2018

Release Note: UI improvements to update variable snapshot to make this feature more accessible

@benjimac93

This comment has been minimized.

Copy link

@benjimac93 benjimac93 commented Jul 9, 2018

<3

@PaulFarry

This comment has been minimized.

Copy link

@PaulFarry PaulFarry commented Jul 14, 2018

One more nice to have for this would be to "Preview" the change instead of just make the change and then review the audit.

@MarkSiedle

This comment has been minimized.

Copy link
Author

@MarkSiedle MarkSiedle commented Jul 17, 2018

Hi Paul, thanks for the feedback. We agree, but for this first draft we looked into the implementation of something like this and decided the links to the audit screen would be a good compromise (as it would help avoid a lot of complexity - especially for customers operating at scale with hundreds/thousands of variables). The concept of a preview is something we've got on the back-burner though, it's just lower on the list of priorities.

@lock

This comment has been minimized.

Copy link

@lock lock bot commented Nov 23, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.