Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS binding without host name whilst also requiring SNI in-descriptively breaks IIS bindings. #4802

Closed
danielfischeroctopus opened this issue Aug 10, 2018 · 2 comments

Comments

@danielfischeroctopus
Copy link

commented Aug 10, 2018

Currently when configuring HTTPS binding in an IIS step, you are able to set no value for Host name yet set Server Name Identification to required.

The end result is a non descriptive error which can be difficult to diagnose.

11:01:54   Info     |       SSL Certificate add failed, Error: 87
11:01:54   Info     |       The parameter is incorrect.

Steps to reproduce:

  1. Create Deploy to IIS step and configure with simple site package.
  2. Set HTTPS binding to either a variable which evaluates to nothing, or leave it empty.
  3. Select Required for Server Name Identification.
  4. After deployment trying to view site bindings in IIS will give you the error The parameter is incorrect.

In the IIS UI you can not select SNI without entering a host name. Octopus ignores this and the provided warning is not descriptive.

We should try and provide a more informative warning to help troubleshoot this easier.

Internal Source: https://secure.helpscout.net/conversation/611271650/28618?folderId=845288

@danielfischeroctopus

This comment has been minimized.

@droyad droyad removed the area/modelling label May 1, 2019

@droyad droyad added the size/tiny label May 16, 2019

@droyad droyad self-assigned this Jun 21, 2019

@droyad droyad closed this Jun 27, 2019

@octoreleasebot octoreleasebot added this to the 2019.5.13 milestone Jun 27, 2019

@octoreleasebot

This comment has been minimized.

Copy link

commented Jun 27, 2019

Release Note: Added validation to the IIS configuration to ensure a hostname is entered when SNI is enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.