Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to skip required steps in guided failure mode #4941

Closed
OctopusBob opened this issue Oct 3, 2018 · 2 comments

Comments

@OctopusBob
Copy link

commented Oct 3, 2018

Are you a customer of Octopus Deploy? Don't raise the issue here. Please contact our support team so we can triage your issue, making sure it's handled appropriately.

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

A step is marked as required. When in guided failure mode it is possible to ignore / skip that step.

What I expected to happen

Required steps cannot be skipped. The guided failure mode options are retry or fail.

Steps to reproduce

  1. Mark a step as required
    requiredstep
  2. Force an error (I messed with IP address settings for Database Deployments)
  3. Create a release and enable guided failure
    enableguidedfailuremode
  4. When the failure happens click on the ignore button. It will move onto the next step.
    abletoignorefailure

Log exerpt

Username found, using SQL Authentication
October 3rd 2018 10:12:19Info
Opening the connection to ********
October 3rd 2018 10:12:35Error
Exception calling "Open" with "0" argument(s): "A network-related or
October 3rd 2018 10:12:35Error
instance-specific error occurred while establishing a connection to SQL
October 3rd 2018 10:12:35Error
Server. The server was not found or was not accessible. Verify that the
October 3rd 2018 10:12:35Error
instance name is correct and that SQL Server is configured to allow remote
October 3rd 2018 10:12:35Error
connections. (provider: Named Pipes Provider, error: 40 - Could not open a
October 3rd 2018 10:12:35Error
connection to SQL Server)"
October 3rd 2018 10:12:35Error
At C:\Octopus\Work\20181003151216-135971-14705\Script.ps1:17 char:1
October 3rd 2018 10:12:35Error

  • $sqlConnection.Open()
    October 3rd 2018 10:12:35Error

October 3rd 2018 10:12:35Error
+ CategoryInfo : NotSpecified: (:) [], ParentContainsErrorRecordE
October 3rd 2018 10:12:35Error
xception
October 3rd 2018 10:12:35Error
+ FullyQualifiedErrorId : SqlException
October 3rd 2018 10:12:35Error

October 3rd 2018 10:12:55Error
The remote script failed with exit code 1
October 3rd 2018 10:12:55Info
Guidance received: Ignore

Affected versions

Octopus Server: 2018.8.7

Workarounds

Restrict who can perform guided failures.

Links

Reported by customer while on a phone call.

@octoreleasebot

This comment has been minimized.

Copy link

commented Nov 15, 2018

Release Note: Guided failure for required steps no longer presents the option to skip the step or exclude a machine from the step

@lock

This comment has been minimized.

Copy link

commented Feb 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.