Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive Template Project variables on a Tenant do not show "value required" warning #5027

Closed
NickJosevski opened this issue Oct 25, 2018 · 3 comments

Comments

@NickJosevski
Copy link

commented Oct 25, 2018

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

Sensitive template doesn't show warnings

What I expected to happen

The 2 controls types should behave the same when they lack a value

Steps to reproduce

  1. Link a Project and a Tenant
  2. Go to Project > Variables > Project Template
  3. Use 'Add Template' to create 2 Project Variable Templates
  4. Make 1 control type "single-line text box", make the other "sensitive/password box"
  5. Save and navigate back to Tenants > Your Tenant > Variables > Expand the section (as per screenshot below)
  6. See that both do not have values yet, but the sensitive one doesn't show a warning

Screen capture

image

Affected versions

Octopus Server: 4.0.0 to 2018.9.0, possibly earlier

Links

https://secure.helpscout.net/conversation/689100770 (internal)

@octoreleasebot octoreleasebot added this to the 2018.9.1 milestone Oct 25, 2018
@octoreleasebot

This comment has been minimized.

Copy link

commented Oct 25, 2018

Release Note: Sensitive Template Project variables on a Tenant will now show "value required" warning when they are empty

@lock

This comment has been minimized.

Copy link

commented Jan 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.