Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Script timeout is too short for .NET upgrade scripts #5038

Closed
michaelnoonan opened this issue Oct 30, 2018 · 2 comments

Comments

@michaelnoonan
Copy link
Contributor

commented Oct 30, 2018

When a SQL Command issued by a .NET upgrade script takes > 30s to complete, it times out. Our T-SQL upgrade scripts use a command timeout of Inifinity because we absolutely want them to succeed.

We should make the command timeout consistent across all upgrade script types.

What I expected to happen

The command timeout should be Infinity because we should keep processing the upgrade regardless of how long it takes.

Affected versions

Octopus Server: 3.16.3 until fixed. Expectation was introduced by #3641

Workarounds

If your upgrade is timing out, there is no workaround. You must upgrade to the version of Octopus Server shown in the Milestone for this Issue.

Links

Related to #5024

@octoreleasebot

This comment has been minimized.

Copy link

commented Nov 5, 2018

Release Note: Database upgrade scripts now use an infinite SQL command timeout consistently - we really want the upgrade to complete even if a particular command takes a longer time than expected

@lock

This comment has been minimized.

Copy link

commented Feb 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.