Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Release steps condition if not current version fails when release has manual intervention step #5058

Closed
distantcam opened this issue Nov 6, 2018 · 2 comments

Comments

@distantcam
Copy link

commented Nov 6, 2018

The bug

When:

  • There's a Deploy Release step
    • And the step is configured to release when the version != current or > current
  • And the release has a manual step
  • And the manual step is aborted

The Deploy Release step completes successfully, even though the release fails because the manual step is aborted.

Workarounds

Setting the Deploy Release step to always release will fix the step (it will fail if the release fails).

Otherwise a manual step can be added after the Deploy Release step to verify the release worked.

Links

https://secure.helpscout.net/conversation/693305936
#4766

@distantcam distantcam self-assigned this Nov 6, 2018
@distantcam distantcam closed this Nov 8, 2018
@octoreleasebot octoreleasebot added this to the 2018.9.7 milestone Nov 8, 2018
@octoreleasebot

This comment has been minimized.

Copy link

commented Nov 8, 2018

Release Note: Fixed issue with Deploy Release step not always failing when the release fails

@lock

This comment has been minimized.

Copy link

commented Feb 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.