Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrator doesn't correctly handle accounts with environment or tenant restrictions #5082

Closed
michaelnoonan opened this issue Nov 13, 2018 · 3 comments

Comments

@michaelnoonan
Copy link
Contributor

commented Nov 13, 2018

Imagine you have an account which is restricted so it can only be used for deployments to certain environments, like Dev and Test. If you export a project which can only be deployed to Test but not Dev, the Dev environment won't be exported since it's not necessary for that project. Now when you import the project, it will fail when importing the account because there is no such environment as Dev in the target.

The same problem exists for tenant restrictions also.

What I expected to happen

When importing an account which is restricted to certain environments, if any of those environments do not exist in the target, remove the restriction instead of failing the import.

Most other places follow this logic. Following suit will make this scenario behave similarly.

Affected versions

Octopus Server: 3.0 until fixed.

Workarounds

Nothing good:

  1. Only perform full exports and imports.
  2. Avoid sharing accounts across projects with different lifecycles and environments, so the export->import contains a consistent list of environments/tenants.
@michaelnoonan

This comment has been minimized.

@octoreleasebot octoreleasebot added this to the 2018.9.10 milestone Nov 14, 2018
@octoreleasebot

This comment has been minimized.

Copy link

commented Nov 14, 2018

Release Note: migrator.exe now correctly handles importing accounts restricted to environments or tenants where some of those environments or tenants do not exist in the target

@lock

This comment has been minimized.

Copy link

commented Feb 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.