Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrator removes variables scoped to tenant tags during import #5101

Closed
michaelnoonan opened this issue Nov 19, 2018 · 3 comments

Comments

@michaelnoonan
Copy link
Contributor

commented Nov 19, 2018

Imagine you have some project variable values scoped to some tenant tags like Region/US or Region/EU. Now imagine you export that project and import it into another Octopus Server instance.

The first time you do this, the variable values are migrated successfully. If you do it again, the variable values are stripped out of the project variable set and a message like this is logged: WARN Variable 'SqlDatabasePassword' dropped, as it was previously scoped to 'TenantTag = (TagSets-121/Tags-151)', but these scopes are not available. This seems very strange since the equivalent tenant tags exist on both the source and destination.

While investigating I discovered a difference between the first and second imports:

First attempt:

Converting TagSet TagSets-121
Created TagSet "Customer.Region" (TagSets-121 -> TagSets-1)

Second attempt:

Converting TagSet TagSets-121
Skipping TagSet "Customer.Region" (TagSets-121) because no overwrites selected
Could not import TagSet "Customer.Region" (TagSets-121)
...
'SqlDatabasePassword' dropped, as it was previously scoped to 'TenantTag = (TagSets-121/Tags-151)

What I expected to happen

It shouldn't matter whether it's the first or subsequent times I'm importing... these particular variables should have been retained. Instead they were removed from the Variable Set.

Affected versions

Octopus Server: 3.4 until fixed.

Workarounds

When importing you can add the --overwrite argument - this will cause the Tenant Tag Sets to be reimported, and the variable values will no longer be dropped - but it may also have the unintended side-effect of overwriting things you didn't intend.

@michaelnoonan

This comment has been minimized.

@MJRichardson MJRichardson added this to the 2018.9.11 milestone Nov 21, 2018
@MJRichardson

This comment has been minimized.

Copy link

commented Nov 21, 2018

Release note: Migrator now correctly remaps tenant tag references when the tag-set exists on the destination

@lock

This comment has been minimized.

Copy link

commented Feb 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.