Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OctopusPrincipalLoader loads a lot of data causing system wide performance problems #5453

Closed
droyad opened this issue Apr 5, 2019 · 10 comments

Comments

@droyad
Copy link
Contributor

commented Apr 5, 2019

Projects and Tenants may have 1000+ records in each, so it is very expensive to load. It should either use the FullTableCache or reduce the data it loads (eg just a few key columns). This was fixed in 2018.5 LTS via OctopusDeploy/OctopusDeploy#3658, but that change can't be applied to 2019.3 or later.

This should be patched on 2019.3 LTS and master

@droyad droyad changed the title OctopusPrincipalLoader loads a lot of datga OctopusPrincipalLoader loads a lot of data Apr 5, 2019
@droyad

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@droyad droyad changed the title OctopusPrincipalLoader loads a lot of data OctopusPrincipalLoader loads a lot of data causing system wide performance problems Apr 5, 2019
@droyad droyad added the size/small label May 27, 2019
@StephenShamakian

This comment has been minimized.

Copy link

commented Jun 3, 2019

@droyad As I wait for Octopus to load a page (takes about 45-60 seconds) I figured I would add my two cents :) I'm glad this finally made it as an issue in GitHub. We been suffering with really slow performance for a few months now after upgrading to the first LTS version. It makes me hesitant to do further feature based upgrades.

@StephenShamakian

This comment has been minimized.

Copy link

commented Jul 8, 2019

@droyad @DerekCampbellOctopus I see some progress has been made on this! :)

Any idea what version of Octopus we should expect to see this in? The slowness bug is really starting to get to us. It's literally almost a minute of waiting for various pages in Octopus to load. We are prepping to move to the latest LTS so were willing to upgrade to get rid of this slowness.

@droyad

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

@slewis74 you've started on this, any estimate?

@slewis74 slewis74 added this to the 2019.3.6 milestone Jul 10, 2019
@slewis74

This comment has been minimized.

Copy link

commented Jul 10, 2019

A fix has already been shipped in fast lane/2019.6, the code has been merged for the fix in 2019.3.6 and is just waiting for it to be shipped. That should ship early next week.

@StephenShamakian

This comment has been minimized.

Copy link

commented Jul 11, 2019

@slewis74 When will it make its way to the LTS lane? Will that be for the next major LTS release? I know there was recently one. Is there any rough timelines on that?

In our development environment we are presently running v2019.6.3 LTS and we still have the same slowness issue that our v2018.10.6 LTS version has.

@droyad

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@StephenShamakian It is in 2019.6.0, so perhaps you are hitting a different slowness problem. This one primarily crops up when you change something related to permissions (users/teams/roles), the next request is slow for each user.

If it's to do with tenants, there are a few other issues (#4845, #5607, #5690). Otherwise have a chat with Derek.

@StephenShamakian

This comment has been minimized.

Copy link

commented Jul 11, 2019

projects_slow
@droyad Drats, I thought this was in response to the slowness we reported a while back now... The slowness we see is from the /api/projects/all API endpoint that is constantly hit in the background. That endpoint takes upwards for 45-60 seconds to load and it breaks the whole page while it loads (loading bar).

See the attached image from v2019.6.3 LTS. Both taking about a minute to load. Both endpoints being the projects/all and this particular slowness was taken on the tasks page. But it happens on various pages (probably any that use that endpoint).

@DerekCampbellOctopus

@droyad

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

Ah right, that's already on our backlog and we even discussed it earlier today. I never raised an issue for it, but I have now #5694.

@slewis74 slewis74 closed this Jul 22, 2019
@octoreleasebot

This comment has been minimized.

Copy link

commented Jul 22, 2019

Release Note: Introduced table caching of user details in server, to address performance issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.