Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate variable not mandatory on IIS binding #5480

Closed
matt-richardson opened this issue Apr 14, 2019 · 2 comments

Comments

@matt-richardson
Copy link
Contributor

commented Apr 14, 2019

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

When Certificate managed by Octopus is selected in the IIS bindings dialog, the Certificate Variable field is not mandatory. This can cause hard to diagnose bugs at deployment time.

image

What I expected to happen

We should validate that a certificate is provided.

Steps to reproduce

  1. Create a project
  2. Add a Deploy to IIS step
  3. Scroll down to 'Bindings'
  4. Add a binding
  5. Select HTTPS
  6. Hit Save
    -> no validation appears

Screen capture

This results in errors like this during deployment:
image

Calamari.exe : Exception calling "Invoke" with "0" argument(s): "You cannot call a method on a null-valued expression." 
At C:\Octopus\localtentacle\Work\20190409225612-1384-4\Bootstrap.ps1:27 char:1 
+ &  "${env:TentacleHome}\Calamari\4.15.3\Calamari.exe" deploy-package  ... 
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
    + CategoryInfo          : NotSpecified: (Exception calli...ed expression.":String) [], RemoteException 
    + FullyQualifiedErrorId : NativeCommandError 
The remote script failed with exit code 1 
The action Deploy Identity Server on local failed 

Affected versions

Octopus Server: 4.0 till fixed

Workarounds

Specify the certificate variable on the binding.

Links

source: https://help.octopus.com/t/we-are-getting-the-below-error-message-whilst-using-https-binding/22665

matt-richardson added a commit to OctopusDeploy/Calamari that referenced this issue Apr 14, 2019
matt-richardson added a commit to OctopusDeploy/Calamari that referenced this issue Apr 15, 2019
@octoreleasebot octoreleasebot added this to the 2019.4.3 milestone Apr 15, 2019
@octoreleasebot

This comment has been minimized.

Copy link

commented Apr 15, 2019

Release Note: Add certificate variable validation for HTTPS binding on the Deploy to IIS step

@lock

This comment has been minimized.

Copy link

commented Jul 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.