Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudFormation changesets errors when no changes to be applied #5523

Closed
shaunmarx opened this issue Apr 30, 2019 · 3 comments

Comments

@shaunmarx
Copy link

commented Apr 30, 2019

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

Currently when there are no changes to be applied for a CloudFormation change set throws an error indicating that there are no changes to be applied.

What I expected to happen

We should not attempt to apply changes and simply generate the output variables resulting the step to succeed instead of fail making things idempotent.

Steps to reproduce

  1. Create a new project and add a Deploy an AWS CloudFormation Template
  2. Ensure you enable the ChangeSet feature and ensure and don't defer execution
  3. Specify a template which creates a resource such as an S3 bucket
{
	"AWSTemplateFormatVersion": "2010-09-09",
	"Parameters": {
		"BucketName": {
			"Description": "Name of S3 Bucket",
			"Type": "String"
		}
	},
	"Resources": {
	  "S3Bucket": {
		"Type": "AWS::S3::Bucket",
		  "Properties": {
			"BucketName": {
			  "Ref": "BucketName"
			}
		  }
		}
	},
	"Outputs": {
	  "S3BucketName": {
		"Value": {
		  "Ref": "S3Bucket"
		},
		"Description": "Name of S3 bucket"
	  }
	}
}
  1. Deploy to the same project more than once
  2. Notice the error

Screen capture

image

Workarounds

In some cases it may be possible to forego change-sets and acknowledge that the current template has macros (CAPABILITY_AUTO_EXPAND) instead.

Links

https://secure.helpscout.net/conversation/834053865/43731?folderId=571737

@shaunmarx

This comment has been minimized.

@octoreleasebot

This comment has been minimized.

Copy link

commented May 2, 2019

Release Note: Fixed an issue where Deploy CloudFormation template step would fail when using the change sets feature and no changes need to be applied

@slewis74 slewis74 modified the milestones: 2019.4.7, 2019.5.0 May 2, 2019
@lock

This comment has been minimized.

Copy link

commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.