Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation dialog when deleting an API Key #5540

Closed
Dalmirog opened this issue May 6, 2019 · 2 comments

Comments

@Dalmirog
Copy link

commented May 6, 2019

Prerequisites

  • I have searched open and closed issues to make sure it isn't already requested
  • I have written a descriptive issue title
  • I have linked the original source of this feature request
  • I have tagged the issue appropriately (area/*, kind/enhancement)

The enhancement

Currently when you click on the [X] button to delete the API Key, it deletes it right away without asking for confirmation. This has caused accidental deletions in the past to many of our users.

The idea is to add a modal confirmation dialog to prevent these accidents.

Mockup

image

@Dalmirog Dalmirog self-assigned this May 6, 2019
@Dalmirog Dalmirog closed this May 7, 2019
@Dalmirog Dalmirog added this to the 2019.5.0 milestone May 7, 2019
@octoreleasebot

This comment has been minimized.

Copy link

commented May 7, 2019

Release Note: Added confirmation dialog before deleting an API Key

@lock

This comment has been minimized.

Copy link

commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.