Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label validation in K8S steps does not allow for prefixes #5587

Closed
mcasperson opened this issue May 26, 2019 · 1 comment

Comments

@mcasperson
Copy link

commented May 26, 2019

Prerequisites

  • [ * ] I have verified the problem exists in the latest version
  • [ * ] I have searched open and closed issues to make sure it isn't already reported
  • [ * ] I have written a descriptive issue title
  • [ * ] I have linked the original source of this report
  • [ * ] I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

The validation for the Kubernetes labels does not allow for a prefix to be assigned. For example, the label example.org/labelname would be considered invalid.

What I expected to happen

Labels with prefixes should be able to be saved.

Steps to reproduce

  1. Add a Deploy kubernetes containers step to a project
  2. In the deployment section add a label with the name example.org/labelname
  3. The validation error Deployment label names must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character, and values must be no more than 63 characters will be displayed

Screen capture

image

Affected versions

All versions to 2019.5.6.

Workarounds

Labels are not validated at create time if they are variables, so setting the label name to something like #{LabelName} and defining the appropiate Octopus variable will allow the step to be saved.

Links

https://secure.helpscout.net/conversation/856476903/44908?folderId=571733

@mcasperson mcasperson added the kind/bug label May 26, 2019
@mcasperson mcasperson added this to the 2019.5.5 milestone May 26, 2019
@mcasperson mcasperson self-assigned this May 26, 2019
@droyad droyad added the size/small label May 27, 2019
@matt-richardson matt-richardson removed this from the 2019.5.5 milestone May 27, 2019
@mcasperson mcasperson closed this May 27, 2019
@mcasperson mcasperson added this to the 2019.5.6 milestone May 27, 2019
@lock

This comment has been minimized.

Copy link

commented Aug 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.