Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI is slow in `2019.5.4` and later #5598

Closed
droyad opened this issue May 30, 2019 · 4 comments

Comments

@droyad
Copy link
Contributor

commented May 30, 2019

It looks like 2019.5.4 does not handle as many request in parallel as previously.

This was tested on two TentacleArmy servers with the same setup (1000 targets, 30 library sets, one project referencing all those sets). One is 2019.5.3 and the other is 2019.5.4.

Full page load (with cache), which issues 86 requests used to take 5.8 seconds, now takes 10 seconds:

https://rw-201953.tentaclearmy.com:8085/app#/Spaces-1/projects/test/variables/all
image

https://rw-201954.tentaclearmy.com:8085/app#/Spaces-1/projects/test/variables/all
image

Drilling down we can see the requests are in parallel in .4 and then serialized in .5. Green is request sent, no response yet. Blue is data being received.

image
image

In the second image the gap between the end of the blue and start of the next blue is likely the latency from the server.

@droyad droyad added the kind/bug label May 30, 2019
@droyad

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

It looks like it could be Nancy v2 or related changes. Here is the Timeline trace of the above page:

2019.5.3
image

Latest master
image

Traces are too big to attach, but I still have them.

@droyad

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

I added a Thread.Sleep to LoadBalancerPingResponder and hit the endpoint. Nothing else would load in any other tab until that had completed.

image

I also tried it via Octopus.Client and it caused that to hang as well.

I did not test how it would behave from different hosts.

@droyad droyad closed this Jun 2, 2019
@octoreleasebot octoreleasebot added this to the 2019.5.7 milestone Jun 2, 2019
@octoreleasebot

This comment has been minimized.

Copy link

commented Jun 2, 2019

Release Note: Fixes a bug introduced in 2019.5.4 that prevented most API requests from being handled in parallel, causing slow downs of the API and UI

@lock

This comment has been minimized.

Copy link

commented Sep 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.