Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native kubectl config masking for verbose logs #5616

Closed
mcasperson opened this issue Jun 10, 2019 · 1 comment

Comments

@mcasperson
Copy link

commented Jun 10, 2019

Prerequisites

  • [ * ] I have searched open and closed issues to make sure it isn't already requested
  • [ * ] I have written a descriptive issue title
  • [ * ] I have linked the original source of this feature request
  • [ * ] I have tagged the issue appropriately (area/*, kind/enhancement)

The enhancement

The Kubernetes config file is printed to the verbose logs for debugging. This was done by dumping the raw config file (if the appropriate Octopus variable was enabled - see OctopusDeploy/OctopusDeploy#3880). Using kubectl config view allows us to take advantage of the built in masking of more sensitive variables.

Links

kubectl itself leaks sensitive data: kubernetes/kubectl#667, so this information is only printed when the Octopus variable Octopus.Action.Kubernetes.OutputKubeConfig is set to true.

@lock

This comment has been minimized.

Copy link

commented Sep 8, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.