Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User password change button permissions #5826

Closed
slewis74 opened this issue Sep 3, 2019 · 1 comment

Comments

@slewis74
Copy link

commented Sep 3, 2019

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

In versions prior to the introduction of Spaces, the User page in the portal would render a permission error immediately if the current user didn't have UserEdit permissions. During the permissions overhaul in the Spaces version the page was changed so that if the user had UserView but not UserEdit the page would still render, they just couldn't save because the button was disabled. The change password button appears to have been missed on the permissions check though, because it still renders as enabled.

What I expected to happen

The API does correctly return an error if you open the dialog and try to set a new password, but the UX is poor and the button should be disabled when we know it can't be used.

Steps to reproduce

As above.

Affected versions

Octopus Server:

= 2019.1

Workarounds

No know workarounds.

Links

https://secure.helpscout.net/conversation/945433378/49510?folderId=909887

@slewis74 slewis74 added the kind/bug label Sep 3, 2019
@slewis74 slewis74 changed the title User password change button permissions - LTS 2019.3 User password change button permissions Sep 4, 2019
@slewis74 slewis74 closed this Sep 4, 2019
@octoreleasebot octoreleasebot added this to the 2019.8.2 milestone Sep 4, 2019
@octoreleasebot

This comment has been minimized.

Copy link

commented Sep 4, 2019

Release Note: Fixed the User edit page so the Reset Password button is only enabled based on the same permissions checks logic the API is using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.