Deployments using `Deploy a Release` step can bypass the task cap

[pawelpabich]

Severity

Blocking customer expansion

Version

2023.4.7864

Latest Version

I could reproduce the problem in the latest build

What happened?

https://github.com/OctopusDeploy/OctopusDeploy/pull/20996 introduced a regression that allows deployments that use Deploy a Release step to bypass the task cap. There is an example of a customer on task cap 40 who managed to get to ~800 running deployments

Reproduction

1. Create a project called Child
2. Add Run a script step to the Child project with the following script Start-Sleep (Get-Random -Minimum 30 -Maximum 60)
3. Create a project called Parent
4. Add Deploy a release step to the Parent project
5. Create 100 Tenants and connected them to both projects
6. Set task cap to 5
7. Deploy the Parent project to all Tenants at once.
8. You will notice 5-10 times more running tasks then what the task allows for

Error and Stacktrace

No response

More Information

https://octopusdeploy.slack.com/archives/C04RY9QLJUE/p1710896095241129

Workaround

Do not use Deploy a release step