Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add packages to ignored_packages while working on them #22

Open
OdatNurd opened this issue Apr 10, 2017 · 3 comments
Open

[FEATURE] Add packages to ignored_packages while working on them #22

OdatNurd opened this issue Apr 10, 2017 · 3 comments

Comments

@OdatNurd
Copy link
Owner

Summary

For any operation that modifies the contents of a package (delete override, cleanup, cleanup of case issues, etc) the package or packages in question should probably be inserted into the list of ignored packages prior to doing the operation, and then removed once they're done.

Some work would have to be done to make sure that this doesn't trigger an automated expiration check when the packages are removed from the list while still making sure that if other operations are happening in the meantime (e.g. something being upgraded or the user un-ignoring something manually) still would.

Possibly this could be done by extending AutoReportTrigger with some static methods you could call to give it a list of packages, and it would add them to the ignored list and take them out, tracking which they were so that it would know it doesn't need to trigger a check.

Questions

This would need to happen if a package directory or override was renamed due to case issues, because the only way to do that is to move the file away to a different name and back (otherwise the underlying OS assumes you're trying to rename a file to itself).

In what other cases would this be needed?

@keith-hall
Copy link
Contributor

This would also be useful when deleting an override because ST doesn't reload the original - sublimehq/sublime_text#922

@OdatNurd
Copy link
Owner Author

Ah yeah, good catch. I think I had that in the back of my head somewhere previously.

The issue doesn't say specifically, but I assume the lack of reloading happens for everything and not just python plugins, right?

@OdatNurd OdatNurd added this to TODO in Task List Apr 10, 2017
@keith-hall
Copy link
Contributor

The issue doesn't say specifically, but I assume the lack of reloading happens for everything and not just python plugins, right?

I'm not about everything - for example, .tmPreferences files seem to be unaffected, but it definitely also happens for .sublime-settings files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants