Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comand-line build instructions clarification #533

Closed
wants to merge 14 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@tomjebo
Copy link
Collaborator

tomjebo commented Jan 7, 2019

add some helpful changes to the comman-line build instructions.

@tomjebo

This comment has been minimized.

Copy link
Collaborator Author

tomjebo commented Jan 7, 2019

@twsouthwick not sure why the OpenXmlBasePart commit got re-added. The main thing here was the README.md build instruction. I found that dotnet build DocumentFormat.OpenXml by itself didn't work. Specifying the .csproj extension when in the correct path works.

@twsouthwick

This comment has been minimized.

Copy link
Collaborator

twsouthwick commented Jan 9, 2019

The weird merge was because you were out of date - I merged master here into it.

README.md Outdated
@@ -144,10 +144,11 @@ To build the Open XML SDK

If you want to use a command line approach:

1. Go to the directory that contains the solution.
1. Go to the directory that contains the project file, i.e. `cd <clone path>\src\DocumentFormat.OpenXml`

This comment has been minimized.

@twsouthwick

twsouthwick Jan 9, 2019

Collaborator

Why are you changing it to the project directory? I always go to the solution directory

This comment has been minimized.

@tomjebo

tomjebo Jan 9, 2019

Author Collaborator

because I ran 'dotnet build DocumentFormat.OpenXml.csproj' from the solution folder and it complained that the csproj wasn't found. I'll rework and include your fixes below.

This comment has been minimized.

@twsouthwick

twsouthwick Jan 9, 2019

Collaborator

Oh - no need to include the csproj. Just run dotnet build

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
@twsouthwick

This comment has been minimized.

Copy link
Collaborator

twsouthwick commented Jan 9, 2019

Not sure if we have any explanation in the readme about ProjectLoadStyle, but by default only .NET Core is built/run/tested. In order to build/run/test all varieties you need to set an environment variable to ProjectLoadStyle=All.

Tom Jebo
@tomjebo

This comment has been minimized.

Copy link
Collaborator Author

tomjebo commented Jan 9, 2019

@twsouthwick does that look better?

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Tom Jebo
@twsouthwick
Copy link
Collaborator

twsouthwick left a comment

There's still an open comment that you should run dotnet test from the solution as well.

twsouthwick and others added some commits Jan 10, 2019

@tomjebo

This comment has been minimized.

Copy link
Collaborator Author

tomjebo commented Jan 11, 2019

@twsouthwick can you review?

* Run `dotnet pack .\src\DocumentFormat.OpenXml\DocumentFormat.OpenXml.csproj` to generate a nupkg.
* Run `dotnet build` to build the SDK and test projects

By default, `dotnet` will build/test/run only the .NET Core target framework. To build all target frameworks, set the ProjectLoadStyle environment variable: `ProjectLoadStyle=All` To see the other values for `ProjectLoadStyle`, please refer to the comments in [Directory.Build.Props](Directory.Build.Props). NOTE: Because the other frameworks will be targeted (like .NET 4.6) when using `ProjectLoadStyle=All`, msbuild.exe is needed instead of dotnet.exe so refer to [appveyor.yml](appveyor.yml) to see the appropriate command lines.

This comment has been minimized.

@twsouthwick

twsouthwick Jan 11, 2019

Collaborator

it's actually only because of .NET 3.5; .NET 4.0+ works fine with the dotnet cli. Also, the .exe isn't really needed, and is technically incorrect on *nix platforms.

* Run `dotnet pack .\src\DocumentFormat.OpenXml\DocumentFormat.OpenXml.csproj` to generate a nupkg.
* Run `dotnet build` to build the SDK and test projects

By default, `dotnet` will build/test/run only the .NET Core target framework. To build all target frameworks, set the ProjectLoadStyle environment variable: `ProjectLoadStyle=All` To see the other values for `ProjectLoadStyle`, please refer to the comments in [Directory.Build.Props](Directory.Build.Props). NOTE: Because the other frameworks will be targeted (like .NET 4.6) when using `ProjectLoadStyle=All`, msbuild.exe is needed instead of dotnet.exe so refer to [appveyor.yml](appveyor.yml) to see the appropriate command lines.

This comment has been minimized.

@twsouthwick

twsouthwick Jan 11, 2019

Collaborator

it's actually only because of .NET 3.5; .NET 4.0+ works fine with the dotnet cli. Also, the .exe isn't really needed, and is technically incorrect on *nix platforms.

tomjebo and others added some commits Jan 18, 2019

@twsouthwick

This comment has been minimized.

Copy link
Collaborator

twsouthwick commented Feb 19, 2019

@tomjebo Did you want to merge this in?

@twsouthwick

This comment has been minimized.

Copy link
Collaborator

twsouthwick commented Mar 15, 2019

I'm going to close this - feel free to reopen when you're ready,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.